Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] relax requirements for sending beacon metadata #88

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[iOS] relax requirements for sending beacon metadata #88

merged 1 commit into from
Oct 20, 2022

Conversation

hborawski
Copy link
Contributor

@hborawski hborawski commented Oct 19, 2022 •
edited by intuit-svc
Loading

Sending metaData.beacon required decoding a specific type before, but the requirement is relaxed now to fit a protocol, and is mapped internally to a encodable structure that matches what the beacon plugin expects

Version

Published prerelease version: 0.3.0-next.3

Changelog

🚀 Enhancement

🐛 Bug Fix

📝 Documentation

Authors: 7

@hborawski hborawski added the patch Increment the patch version when merged label Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 77.01% // Head: 77.01% // No change to project coverage 👍

Coverage data is based on head (a2df624) compared to base (88bfa54).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   77.01%   77.01%           
=======================================
  Files         129      129           
  Lines        4499     4499           
  Branches     1114     1114           
=======================================
  Hits         3465     3465           
  Misses        754      754           
  Partials      280      280

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hborawski hborawski merged commit 92ff004 into main Oct 20, 2022
@hborawski hborawski deleted the beaconable-metadata branch October 20, 2022 00:08
This was referenced Oct 25, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KetanReddy KetanReddy Awaiting requested review from KetanReddy

@adierkens adierkens Awaiting requested review from adierkens

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hborawski